Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758498Ab2EBCin (ORCPT ); Tue, 1 May 2012 22:38:43 -0400 Received: from fw.wantstofly.org ([80.101.37.227]:61098 "EHLO mail.wantstofly.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757502Ab2EBCil (ORCPT ); Tue, 1 May 2012 22:38:41 -0400 Date: Wed, 2 May 2012 04:38:36 +0200 From: Lennert Buytenhek To: Pat Erley Cc: sedat.dilek@gmail.com, Sedat Dilek , "John W. Linville" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lautriv , Jim Cromie , Ben Hutchings , Hauke Mehrtens Subject: Re: [PATCH] mwl8k: Add 0x2a02 PCI device-id (Marvell 88W8361) Message-ID: <20120502023836.GW3157@wantstofly.org> References: <20120427101732.GX3157@wantstofly.org> <20120427185809.GZ3157@wantstofly.org> <20120501125102.GN3157@wantstofly.org> <4FA089F9.1020602@erley.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FA089F9.1020602@erley.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 682 Lines: 22 On Tue, May 01, 2012 at 09:12:25PM -0400, Pat Erley wrote: > >--- a/drivers/net/wireless/mwl8k.c > >+++ b/drivers/net/wireless/mwl8k.c > >@@ -5225,6 +5225,7 @@ static void mwl8k_finalize_join_worker(struct work_struct *work) > > } > > > > enum { > >+ MWL8361P = 0, > > MWL8363 = 0, > > MWL8687, > > MWL8366, > > I'm not an expert, but isn't this giving both 8361P and 8363 the > same values in the enum? Yeah, this is broken. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/