Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755853Ab2EBI67 (ORCPT ); Wed, 2 May 2012 04:58:59 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:64257 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755289Ab2EBI65 convert rfc822-to-8bit (ORCPT ); Wed, 2 May 2012 04:58:57 -0400 MIME-Version: 1.0 Reply-To: sedat.dilek@gmail.com In-Reply-To: <20120502023836.GW3157@wantstofly.org> References: <20120427101732.GX3157@wantstofly.org> <20120427185809.GZ3157@wantstofly.org> <20120501125102.GN3157@wantstofly.org> <4FA089F9.1020602@erley.org> <20120502023836.GW3157@wantstofly.org> Date: Wed, 2 May 2012 10:58:56 +0200 Message-ID: Subject: Re: [PATCH] mwl8k: Add 0x2a02 PCI device-id (Marvell 88W8361) From: Sedat Dilek To: Lennert Buytenhek Cc: Pat Erley , "John W. Linville" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lautriv , Jim Cromie , Ben Hutchings , Hauke Mehrtens Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1299 Lines: 45 On Wed, May 2, 2012 at 4:38 AM, Lennert Buytenhek wrote: > On Tue, May 01, 2012 at 09:12:25PM -0400, Pat Erley wrote: > >> >--- a/drivers/net/wireless/mwl8k.c >> >+++ b/drivers/net/wireless/mwl8k.c >> >@@ -5225,6 +5225,7 @@ static void mwl8k_finalize_join_worker(struct work_struct *work) >> >  } >> > >> >  enum { >> >+    MWL8361P = 0, >> >     MWL8363 = 0, >> >     MWL8687, >> >     MWL8366, >> >> I'm not an expert, but isn't this giving both 8361P and 8363 the >> same values in the enum? > > Yeah, this is broken. Before this email, Helmut pointed me to the enum thingie in a private query. As I was busy with OverlayFS the last days, I couldn't give that information back. So, this should be: ... enum { MWL8361P = 0, MWL8363, MWL8687, MWL8366, ... Shall I cook up a new patch with a proper history and documented origin (original patch is from OpenWrt, I refreshed it against upstream)? ...add some Tested-by (Helmut, Jim)... ...send that to linux-wireless ML for a review? - Sedat - -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/