Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754528Ab2EBOHX (ORCPT ); Wed, 2 May 2012 10:07:23 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:33161 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752382Ab2EBOHW convert rfc822-to-8bit (ORCPT ); Wed, 2 May 2012 10:07:22 -0400 MIME-Version: 1.0 In-Reply-To: References: <1335924760-796-1-git-send-email-rob.lee@linaro.org> <1335924760-796-2-git-send-email-rob.lee@linaro.org> <20120502031311.GT2194@S2101-09.ap.freescale.net> Date: Wed, 2 May 2012 22:07:20 +0800 Message-ID: Subject: Re: [PATCH v2 1/3] ARM: imx: Add common imx cpuidle init functionality. From: Shawn Guo To: Rob Lee Cc: kernel@pengutronix.de, amit.kucheria@linaro.org, daniel.lezcano@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org, patches@linaro.org, jj@chaosbits.net Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 711 Lines: 21 On 2 May 2012 21:59, Rob Lee wrote: >>> + ? ? ? ? ? ? ret = cpuidle_register_device(dev); >>> + ? ? ? ? ? ? if (ret) { >>> + ? ? ? ? ? ? ? ? ? ? pr_err("%s: Failed to register cpu %u\n", >>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? __func__, cpu_id); >> >> Nit: print ret (error code) too? >> > > I added the printing of the error code based on Sascha's suggestion in > v1 of this submission. > But you did not print "ret" in above pr_err. Regards, Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/