Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757173Ab2EBUMm (ORCPT ); Wed, 2 May 2012 16:12:42 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:41383 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756994Ab2EBUMl convert rfc822-to-8bit (ORCPT ); Wed, 2 May 2012 16:12:41 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Thu, 3 May 2012 02:12:39 +0600 Message-ID: Subject: Re: staging/rtl8712: unhandled default case in SwLedOn function. From: joseph daniel To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Ali Bahar , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1199 Lines: 38 On Thu, May 3, 2012 at 2:10 AM, joseph daniel wrote: > Hi kernel developers, > > In the function SwLedOn in rtl8712_led.c, we put the bLedOn = true, > even if its a default case. may be we need to return? or BUG()?. > > the code listing is: > > if ((padapter->bSurpriseRemoved == true) || > ? ? ? ?(padapter->bDriverStopped == true)) > ? ? ? ?return; > ? ?LedCfg = r8712_read8(padapter, LEDCFG); > ? ?switch (pLed->LedPin) { > ? ?case LED_PIN_GPIO0: > ? ? ? ?break; > ? ?case LED_PIN_LED0: > ? ? ? ?/* SW control led0 on.*/ > ? ? ? ?r8712_write8(padapter, LEDCFG, LedCfg&0xf0); > ? ? ? ?break; > ? ?case LED_PIN_LED1: > ? ? ? ?/* SW control led1 on.*/ > ? ? ? ?r8712_write8(padapter, LEDCFG, LedCfg&0x0f); > ? ? ? ?break; > ? ?default: /* at this point of the code */ > ? ? ? /*?break; */ return; /* or */ /* BUG(); */ /*since we may not be getting into here */ > ? ?} > ? ?pLed->bLedOn = true; > Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/