Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757407Ab2EBUhG (ORCPT ); Wed, 2 May 2012 16:37:06 -0400 Received: from mail-gy0-f174.google.com ([209.85.160.174]:36118 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756801Ab2EBUhB (ORCPT ); Wed, 2 May 2012 16:37:01 -0400 Message-ID: <4FA19AE9.104@lwfinger.net> Date: Wed, 02 May 2012 15:36:57 -0500 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120328 Thunderbird/11.0.1 MIME-Version: 1.0 To: joseph daniel CC: Florian Schilhabel , Greg Kroah-Hartman , Ali Bahar , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: staging/rtl8712: unhandled default case in SwLedOn function. References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1842 Lines: 59 On 05/02/2012 03:12 PM, joseph daniel wrote: > On Thu, May 3, 2012 at 2:10 AM, joseph daniel > wrote: >> Hi kernel developers, >> >> In the function SwLedOn in rtl8712_led.c, we put the bLedOn = true, >> even if its a default case. may be we need to return? or BUG()?. >> >> the code listing is: >> >> if ((padapter->bSurpriseRemoved == true) || >> (padapter->bDriverStopped == true)) >> return; >> LedCfg = r8712_read8(padapter, LEDCFG); >> switch (pLed->LedPin) { >> case LED_PIN_GPIO0: >> break; >> case LED_PIN_LED0: >> /* SW control led0 on.*/ >> r8712_write8(padapter, LEDCFG, LedCfg&0xf0); >> break; >> case LED_PIN_LED1: >> /* SW control led1 on.*/ >> r8712_write8(padapter, LEDCFG, LedCfg&0x0f); >> break; >> default: > /* at this point of the code */ >> /* break; */ > return; /* or */ > /* BUG(); */ /*since we may not be getting into here */ >> } >> pLed->bLedOn = true; >> This should do: Index: staging/drivers/staging/rtl8712/rtl8712_led.c =================================================================== --- staging.orig/drivers/staging/rtl8712/rtl8712_led.c +++ staging/drivers/staging/rtl8712/rtl8712_led.c @@ -137,7 +137,8 @@ static void SwLedOn(struct _adapter *pad r8712_write8(padapter, LEDCFG, LedCfg&0x0f); break; default: - break; + WARN_ONCE(1, "Default branch taken in %s\n", __func__); + return; } pLed->bLedOn = true; } If you agree, then I will push the patch to Greg. Larry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/