Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754612Ab2ECAXV (ORCPT ); Wed, 2 May 2012 20:23:21 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:53026 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752989Ab2ECAXT convert rfc822-to-8bit (ORCPT ); Wed, 2 May 2012 20:23:19 -0400 MIME-Version: 1.0 In-Reply-To: <201204262352.43254.rjw@sisk.pl> References: <201202070200.55505.rjw@sisk.pl> <201204222323.23685.rjw@sisk.pl> <20120426130503.7f55415d@notabene.brown> <201204262352.43254.rjw@sisk.pl> Date: Wed, 2 May 2012 17:23:18 -0700 Message-ID: Subject: Re: [RFC][PATCH 6/8] PM / Sleep: Implement opportunistic sleep From: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= To: "Rafael J. Wysocki" Cc: NeilBrown , Linux PM list , LKML , Magnus Damm , markgross@thegnar.org, Matthew Garrett , Greg KH , John Stultz , Brian Swetland , Alan Stern , Dmitry Torokhov , "Srivatsa S. Bhat" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1694 Lines: 46 On Thu, Apr 26, 2012 at 2:52 PM, Rafael J. Wysocki wrote: ... > From: Rafael J. Wysocki > Subject: PM / Sleep: Implement opportunistic sleep, v2 > > Introduce a mechanism by which the kernel can trigger global > transitions to a sleep state chosen by user space if there are no > active wakeup sources. > > It consists of a new sysfs attribute, /sys/power/autosleep, that > can be written one of the strings returned by reads from > /sys/power/state, an ordered workqueue and a work item carrying out > the "suspend" operations. ?If a string representing the system's > sleep state is written to /sys/power/autosleep, the work item > triggering transitions to that state is queued up and it requeues > itself after every execution until user space writes "off" to > /sys/power/autosleep. > This does not work. Writing something other than "off" disabled auto suspend for me. ... > +static ssize_t autosleep_store(struct kobject *kobj, > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?struct kobj_attribute *attr, > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?const char *buf, size_t n) > +{ > + ? ? ? suspend_state_t state = decode_state(buf, n); > + ? ? ? int error; > + > + ? ? ? if (state == PM_SUSPEND_ON > + ? ? ? ? ? && !(strncmp(buf, "off", 3) && strncmp(buf, "off\n", 4))) > + ? ? ? ? ? ? ? return -EINVAL; Did you mean: if (state == PM_SUSPEND_ON && strcmp(buf, "off") && strcmp(buf, "off\n")) return -EINVAL; -- Arve Hj?nnev?g -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/