MIME-Version: 1.0
In-Reply-To: <20120502230654.GB6926@localhost>
References: <201205021441.q42Ef1ap026902@drepperk.user.openhosting.com>
 <4FA17A95.9050603@gmail.com> <20120502230654.GB6926@localhost>
From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
Date: Wed, 2 May 2012 21:41:11 -0400
Message-ID: <CAHGf_=oMo4Rii8e=V5OTeCJoMc2wTY6Cx1HzKaaGzHT5TL30yw@mail.gmail.com>
Subject: Re: [PATCH] Cleanup page-type.c
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Ulrich Drepper <drepper@akkadia.org>, akpm@linux-foundation.org,
        dyoung@redhat.com, linux-kernel@vger.kernel.org,
        n-horiguchi@ah.jp.nec.com
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1844
Lines: 46

On Wed, May 2, 2012 at 7:06 PM, Fengguang Wu <fengguang.wu@intel.com> wrote:
> On Wed, May 02, 2012 at 02:19:01PM -0400, KOSAKI Motohiro wrote:
>> (5/2/12 10:41 AM), Ulrich Drepper wrote:
>> > Compiling page-type.c with a recent compiler produces many warnings,
>> > mostly related to signed/unsigned comparisons. ?This patch cleans up
>> > most of them.
>> >
>> > One remaining warning is about an unused parameter. ?The<compiler.h>
>> > file doesn't define a __unused macro (or the like) yet. ?This can be
>> > addressed later.
>> >
>> > The line numbers for this patch correspond to the file changed to remove
>> > the duplicate definitions of the KPF_* macros which is contained in
>> > another patch. ?It should apply cleanly albeit with warnings even without
>> > that patch applied first.
>> >
>> >
>> > Signed-off-by: Ulrich Drepper<drepper@gmail.com>
>> >
>> > ? page-types.c | ? 22 +++++++++++-----------
>> > ? 1 file changed, 11 insertions(+), 11 deletions(-)
>>
>> Looks good to me.
>> ?Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>
> Acked-by: Fengguang Wu <fengguang.wu@intel.com>
>
>> offtopic:
>> Wu, I have (unrelated) one question. page-type is used from production
>> systems nowadays. Why don't you want to move page-type.c into tools/ dir?
>
> I was actually thinking the same with you, and the good news is, it's
> recently moved into tools/ by Dave Young:
>
> commit c6dd897f3bfc54a44942d742d6dfa842e33d88e0
> Author: Dave Young <dyoung@redhat.com>
> Date: ? Wed Mar 28 14:42:55 2012 -0700
>
> ? ?mm: move page-types.c from Documentation to tools/vm

Nice! :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/