Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754277Ab2ECNO2 (ORCPT ); Thu, 3 May 2012 09:14:28 -0400 Received: from smtprelay-b11.telenor.se ([62.127.194.20]:60231 "EHLO smtprelay-b11.telenor.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270Ab2ECNO1 (ORCPT ); Thu, 3 May 2012 09:14:27 -0400 X-SENDER-IP: [85.230.168.62] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AiZ3AJWDok9V5qg+PGdsb2JhbABFii+nHwSBIRkBAQEBNzSCCQEBBAE6HCMFCwgDRhQlChouh20JunQTixWEfWMElX2GBo0n X-IronPort-AV: E=Sophos;i="4.75,524,1330902000"; d="scan'208";a="31789643" From: "Henrik Rydberg" Date: Thu, 3 May 2012 15:19:04 +0200 To: Benjamin Tissoires Cc: Jiri Kosina , Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Stephane Chatty Subject: Re: [PATCH v3 0/6] hid: Introduce device groups Message-ID: <20120503131904.GA11741@polaris.bitmath.org> References: <1335175627-2270-1-git-send-email-rydberg@euromail.se> <20120503122359.GA11552@polaris.bitmath.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2398 Lines: 53 > > 1) Add the devices in question back to the have_special_drivers list. > > Well... The device presents valid mouse and keyboard interface that > should be handled by hid-generic. > The behavior of this particular device is the following: > - when 1 finger is in use, then it sends events over the mouse interface > - when 2 fingers are present, it sends events over the multitouch interface > - when you physically trigger the switch mode button, a keyboard > appears and it sends key events over the keyboard interface, and > eventually mouse events if you press the "mouse" key.... ;-) > > This crap is all inherited by the fact that Microsoft do not want to > handle indirect touch, and the device maker found this solution to > counter this. > > To sum up, adding it to the have_special_drivers driver list won't > work as we need part of the device to be handled by hid-generic. So was this particular device never listed in have_special_drivers? > > 2) Add the interface type to the group descision, which should > > probably be done anyway. I have a patch in the pipe that, will send it > > later today. > > A simpler solution consists in adding the macros HID_USB_MT_DEVICE(v, > p) and HID_BLUETOOTH_MT_DEVICE(v, p) as you had introduced in a > earlier patch (I don't know why it disappeared). No, the specific entries in the hid-multitouch device list matches any group, so those defines were simplified away in the second version. > The problem came out because: > - hid-multitouch registered the triplet BUS_USB / VID / PID. > - For each interface, it asks udev (or the kernel) which driver to > use, and whatever .group was, it was always hid-multitouch that came > out. > > So it's just safer to specify the group for all multitouch devices. This is still confusing. I thought the real problem was that the non-mt interfaces do not match hid-generic. Solution 2) should take care of that. What I don't understand is how those other interfaces came to be handled by hid-generic before this patch, unless this device was never listed in have_special_driver. Are we talking about USB_DEVICE_ID_TOPSEED2_PERIPAD_701 here? Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/