Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755386Ab2ECNX1 (ORCPT ); Thu, 3 May 2012 09:23:27 -0400 Received: from ogre.sisk.pl ([193.178.161.156]:51289 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752160Ab2ECNXZ convert rfc822-to-8bit (ORCPT ); Thu, 3 May 2012 09:23:25 -0400 From: "Rafael J. Wysocki" To: Arve =?iso-8859-1?q?Hj=F8nnev=E5g?= Subject: Re: [RFC][PATCH 6/8] PM / Sleep: Implement opportunistic sleep Date: Thu, 3 May 2012 15:28:12 +0200 User-Agent: KMail/1.13.6 (Linux/3.4.0-rc5+; KDE/4.6.0; x86_64; ; ) Cc: NeilBrown , Linux PM list , LKML , Magnus Damm , markgross@thegnar.org, Matthew Garrett , Greg KH , John Stultz , Brian Swetland , Alan Stern , Dmitry Torokhov , "Srivatsa S. Bhat" References: <201202070200.55505.rjw@sisk.pl> <201204262352.43254.rjw@sisk.pl> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Message-Id: <201205031528.12743.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2466 Lines: 72 On Thursday, May 03, 2012, Arve Hj?nnev?g wrote: > On Thu, Apr 26, 2012 at 2:52 PM, Rafael J. Wysocki wrote: > ... > > From: Rafael J. Wysocki > > Subject: PM / Sleep: Implement opportunistic sleep, v2 > > > > Introduce a mechanism by which the kernel can trigger global > > transitions to a sleep state chosen by user space if there are no > > active wakeup sources. > > > > It consists of a new sysfs attribute, /sys/power/autosleep, that > > can be written one of the strings returned by reads from > > /sys/power/state, an ordered workqueue and a work item carrying out > > the "suspend" operations. If a string representing the system's > > sleep state is written to /sys/power/autosleep, the work item > > triggering transitions to that state is queued up and it requeues > > itself after every execution until user space writes "off" to > > /sys/power/autosleep. > > > > This does not work. Writing something other than "off" disabled auto > suspend for me. My bad, sorry about that. > ... > > +static ssize_t autosleep_store(struct kobject *kobj, > > + struct kobj_attribute *attr, > > + const char *buf, size_t n) > > +{ > > + suspend_state_t state = decode_state(buf, n); > > + int error; > > + > > + if (state == PM_SUSPEND_ON > > + && !(strncmp(buf, "off", 3) && strncmp(buf, "off\n", 4))) > > + return -EINVAL; > > Did you mean: > if (state == PM_SUSPEND_ON > && strcmp(buf, "off") && strcmp(buf, "off\n")) > return -EINVAL; Yes, I did. I'll add the following as an incremental patch on top of the series. Thanks, Rafael --- kernel/power/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/kernel/power/main.c =================================================================== --- linux.orig/kernel/power/main.c +++ linux/kernel/power/main.c @@ -422,7 +422,7 @@ static ssize_t autosleep_store(struct ko int error; if (state == PM_SUSPEND_ON - && !(strncmp(buf, "off", 3) && strncmp(buf, "off\n", 4))) + && strncmp(buf, "off", 3) && strncmp(buf, "off\n", 4)) return -EINVAL; error = pm_autosleep_set_state(state); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/