Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757858Ab2ECRlm (ORCPT ); Thu, 3 May 2012 13:41:42 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:48107 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753784Ab2ECRll (ORCPT ); Thu, 3 May 2012 13:41:41 -0400 Message-ID: <4FA2C34F.5060406@wwwdotorg.org> Date: Thu, 03 May 2012 11:41:35 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.28) Gecko/20120313 Thunderbird/3.1.20 MIME-Version: 1.0 To: Hiroshi DOYU CC: linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Felipe Balbi , Arnd Bergmann , Colin Cross , Olof Johansson , Russell King , Grant Likely , Rob Herring , Greg Kroah-Hartman , Ohad Ben-Cohen , Linus Walleij , "John W. Linville" , MyungJoo Ham , linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org Subject: Re: [PATCHv3 1/4] ARM: tegra: Add Tegra AHB driver References: <1336061147-10245-1-git-send-email-hdoyu@nvidia.com> In-Reply-To: <1336061147-10245-1-git-send-email-hdoyu@nvidia.com> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1473 Lines: 41 On 05/03/2012 10:05 AM, Hiroshi DOYU wrote: > Tegra AHB Bus conforms to the AMBA Specification (Rev 2.0) Advanced > High-performance Bus (AHB) architecture. > > The AHB Arbiter controls AHB bus master arbitration. This effectively > forms a second level of arbitration for access to the memory > controller through the AHB Slave Memory device. The AHB pre-fetch > logic can be configured to enhance performance for devices doing > sequential access. Each AHB master is assigned to either the high or > low priority bin. Both Tegra20/30 have this AHB bus. > > Some of configuration param could be passed from DT too. > diff --git a/drivers/amba/tegra-ahb.c b/drivers/amba/tegra-ahb.c > +static u32 tegra_ahb_gizmo[] = { const? > +static int __init tegra_ahb_module_init(void) > +{ > + return platform_driver_register(&tegra_ahb_driver); > +} > +postcore_initcall(tegra_ahb_module_init); Can this be a module_init() instead of postcore_initcall()? > + > +static void __exit tegra_ahb_module_exit(void) > +{ > + platform_driver_unregister(&tegra_ahb_driver); > +} > +module_exit(tegra_ahb_module_exit); If so, all of the previous two quoted chunks can be replaced with just: module_platform_driver(tegra_ahb_module_init); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/