MIME-Version: 1.0
In-Reply-To: <20120503233239.GB9582@kroah.com>
References: <20120503231903.02D1D8095E@fiasco.mtv.corp.google.com>
	<20120503233239.GB9582@kroah.com>
Date: Thu, 3 May 2012 16:39:47 -0700
Message-ID: <CA+=D-XUBuaT=d=YYou5ZQKM3h9kJcsRM0HCJmLDXfXHZrth0Eg@mail.gmail.com>
Subject: Re: [PATCH] driver-core: fix DEVICE_INT_ATTR to use correct
 show/store functions
From: Michael Davidson <md@google.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1136
Lines: 32

I found the problem while porting some code to 3.3.

It looks as if the mce driver uses int attributes for a few things so I assume
that is broken but I have not actually verified it.

thanks,

md

On Thu, May 3, 2012 at 4:32 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, May 03, 2012 at 04:19:02PM -0700, Michael Davidson wrote:
>> [PATCH] driver-core: fix DEVICE_INT_ATTR to use correct show/store functions
>
> This line isn't needed again in the patch body like this :(
>
>> DEVICE_INT_ATTR() should use device_show_int() and device_store_int()
>> not device_show_ulong() and device_store_ulong()
>>
>> Signed-off-by: Michael Davidson <md@google.com>
>
> Is this something that fixes a problem you have seen, so it needs to go
> in now, and backported to stable kernel releases, or can it wait for 3.5
> and you found it just by looking at the code?
>
> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/