Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757942Ab2EDNIl (ORCPT ); Fri, 4 May 2012 09:08:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52831 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756361Ab2EDNIk (ORCPT ); Fri, 4 May 2012 09:08:40 -0400 Message-ID: <4FA3D4B1.9040308@redhat.com> Date: Fri, 04 May 2012 15:08:01 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120425 Thunderbird/12.0 MIME-Version: 1.0 To: Mark Lord CC: Alan Cox , Jan Kara , Jens Axboe , LKML , James Bottomley , linux-scsi@vger.kernel.org Subject: Re: [PATCH] scsi: Silence unnecessary warnings about ioctl to partition References: <1335953452-10460-1-git-send-email-jack@suse.cz> <4FA1092E.9090603@redhat.com> <20120502115447.7dcc3a54@pyramind.ukuu.org.uk> <4FA11454.2010103@redhat.com> <20120502121208.3c19a9bc@pyramind.ukuu.org.uk> <4FA11963.3040007@redhat.com> <4FA18D33.3060607@teksavvy.com> <4FA23809.2090905@redhat.com> <4FA27CDB.2080103@teksavvy.com> <4FA27E7C.6070802@redhat.com> <4FA2C205.3030801@teksavvy.com> <4FA3799A.6010908@redhat.com> <4FA3D442.9050801@teksavvy.com> In-Reply-To: <4FA3D442.9050801@teksavvy.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1562 Lines: 35 Il 04/05/2012 15:06, Mark Lord ha scritto: >> > I said which ioctls, not which options. I.e. cut-and-paste from dmesg. > Here are some: Thanks! > messages.1:Apr 28 14:08:09 zbox5 kernel: [ 268.800536] hdparm: sending ioctl 330 to a partition! > messages.1:Apr 28 14:08:09 zbox5 kernel: [ 268.800547] hdparm: sending ioctl 330 to a partition! > messages.1:Apr 28 14:08:57 zbox5 kernel: [ 316.413944] hdparm: sending ioctl 330 to a partition! > messages.1:Apr 28 14:08:57 zbox5 kernel: [ 316.413951] hdparm: sending ioctl 330 to a partition! > messages.1:Apr 28 14:20:10 zbox5 kernel: [ 989.525085] hdparm: sending ioctl 330 to a partition! > messages.1:Apr 28 14:20:10 zbox5 kernel: [ 989.525093] hdparm: sending ioctl 330 to a partition! > > The in say this about 330: > > ... > /* 0x330 is reserved - used to be HDIO_GETGEO_BIG */ > ... > > So it's HDIO_GETGEO_BIG, which doesn't exist in newer kernels. > I wonder when that got removed? Minor userspace breakage there. > > hdparm issues it first as a backward-compatibility thing, > before falling back to the even-more obsolete HDIO_GETGEO, > which curiously enough is still in modern kernels. Ok, so hdparm is not broken. My patch (which left the warning only for SG_IO, and failed all other ioctls) would have worked, too. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/