Date: Fri, 4 May 2012 14:59:40 -0300
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>, a.p.zijlstra@chello.nl, mingo@elte.hu,
        paulus@samba.org, cjashfor@linux.vnet.ibm.com, fweisbec@gmail.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 0/4] perf, tool: Fix endian issues
Message-ID: <20120504175940.GC29365@infradead.org>
References: <1336151493-8328-1-git-send-email-jolsa@redhat.com>
 <4FA41481.7000704@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4FA41481.7000704@gmail.com>
User-Agent: Mutt/1.5.20 (2009-12-10)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1116
Lines: 26

Em Fri, May 04, 2012 at 11:40:17AM -0600, David Ahern escreveu:
> On 5/4/12 11:11 AM, Jiri Olsa wrote:
> >hi,
> >sending fixies to properly handle perf.data endians.
> >
> >v2 changes:
> >   - added patches 3 and 4 to handle sample_id_all header endianity
> >
> >Attached patches:
> >   1/4 perf, tool: Handle different endians properly during symbol load
> >   2/4 perf, tool: Carry perf_event_attr bitfield throught different endians
> >   3/4 perf, tool: Handle endianity swap on sample_id_all header data
> >   4/4 perf, tool: Fix 32 bit values endianity swap for sample_id_all header
> 
> Have you tested these patches by collecting data on PPC (or other
> big endian) and analyzing on Intel x86 and vice versa?

I think so, but indeed it is good practice to show the sequence made to
test the changes, with sample, short command output before and after.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/