Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760029Ab2EDWCt (ORCPT ); Fri, 4 May 2012 18:02:49 -0400 Received: from cassiel.sirena.org.uk ([80.68.93.111]:53542 "EHLO cassiel.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756625Ab2EDWCs (ORCPT ); Fri, 4 May 2012 18:02:48 -0400 Date: Fri, 4 May 2012 23:02:41 +0100 From: Mark Brown To: Joe Perches Cc: Mauro Carvalho Chehab , "James E.J. Bottomley" , linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: drivers: Probable misuses of || Message-ID: <20120504220241.GA6279@sirena.org.uk> References: <1333580415.23520.29.camel@joe2Laptop> <1336168477.11505.6.camel@joe2Laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1336168477.11505.6.camel@joe2Laptop> X-Cookie: The bug stops here. User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: broonie@sirena.org.uk X-SA-Exim-Scanned: No (on cassiel.sirena.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 919 Lines: 21 On Fri, May 04, 2012 at 02:54:37PM -0700, Joe Perches wrote: > On Wed, 2012-04-04 at 16:00 -0700, Joe Perches wrote: > > drivers/media/dvb/dvb-usb/it913x.c: if (ret == 0 || ret != -EBUSY || ret != -ETIMEDOUT) > > drivers/media/dvb/dvb-usb/it913x.c: if (ret == 0 || ret != -EBUSY || ret != -ETIMEDOUT) > > drivers/media/rc/fintek-cir.c: if ((chip != 0x0408) || (chip != 0x0804)) > It's been a month. > Do you maintainers not care > about these obvious defects? It'd probably help if you were to supply more analysis as to what the issues you think you're seeing are - in the cases quoted above (especially the last one) there's no obvious bug without further analysis. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/