Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758738Ab2EEBvo (ORCPT ); Fri, 4 May 2012 21:51:44 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:39797 "EHLO mail-pz0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758510Ab2EEBvm (ORCPT ); Fri, 4 May 2012 21:51:42 -0400 From: Adarsh J To: Dmitry Kasatkin , James Morris , Tetsuo Handa , Mimi Zohar , David Howells Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Adarsh J Subject: [PATCH 1/1] lib/mpi: Fixed erroneous check on return value of mpi_resize() Date: Sat, 5 May 2012 07:21:07 +0530 Message-Id: <1336182667-9784-1-git-send-email-root@hackmaster.in> X-Mailer: git-send-email 1.7.9.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 931 Lines: 28 mpi_resize() returns -ENOMEM on error and 0 on success. Signed-off-by: Adarsh J --- lib/mpi/mpicoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/mpi/mpicoder.c b/lib/mpi/mpicoder.c index f26b41f..9949b69 100644 --- a/lib/mpi/mpicoder.c +++ b/lib/mpi/mpicoder.c @@ -98,7 +98,7 @@ int mpi_fromstr(MPI val, const char *str) nbytes = (nbits + 7) / 8; nlimbs = (nbytes + BYTES_PER_MPI_LIMB - 1) / BYTES_PER_MPI_LIMB; if (val->alloced < nlimbs) - if (!mpi_resize(val, nlimbs)) + if (mpi_resize(val, nlimbs) < 0) return -ENOMEM; i = BYTES_PER_MPI_LIMB - nbytes % BYTES_PER_MPI_LIMB; i %= BYTES_PER_MPI_LIMB; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/