Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753505Ab2EEHjo (ORCPT ); Sat, 5 May 2012 03:39:44 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:63425 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753285Ab2EEHjm (ORCPT ); Sat, 5 May 2012 03:39:42 -0400 Message-ID: <4FA4D93A.6090103@suse.cz> Date: Sat, 05 May 2012 09:39:38 +0200 From: Jiri Slaby User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120428 Thunderbird/14.0a2 MIME-Version: 1.0 To: Mikulas Patocka CC: Guy Martin , Linus Torvalds , "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert 5dd5bc40f3b6e0ccdaad948dbadc94ad0906cb25 References: In-Reply-To: X-Enigmail-Version: 1.5pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1401 Lines: 44 On 05/05/2012 05:04 AM, Mikulas Patocka wrote: > Hi > > This patch reverts commit 5dd5bc40f3b6e0ccdaad948dbadc94ad0906cb25. > > The commit 5dd5bc40f3b6e0ccdaad948dbadc94ad0906cb25 causes system lockup > when pdc is used as a boot console. > > The kernel boots, but it locks up when transferring control to userspace > --- the message "INIT: version 2.86 booting" is not printed and the > computer halts. With the patch reverted, the system starts normally on > pdc. ... > --- a/arch/parisc/kernel/pdc_cons.c > +++ b/arch/parisc/kernel/pdc_cons.c ... > @@ -104,10 +103,8 @@ static int pdc_console_tty_open(struct tty_struct *tty, struct file *filp) > > static void pdc_console_tty_close(struct tty_struct *tty, struct file *filp) > { > - if (!tty->count) { > + if (!tty->count) Heh, I cannot find a bug in the patch proper. However this test is and always was bogus. Does changing "!tty->count" to "tty->count == 1" help? > del_timer_sync(&pdc_console_timer); > - tty_port_tty_set(&tty_port, NULL); > - } > } > > static int pdc_console_tty_write(struct tty_struct *tty, const unsigned char *buf, int count) regards, -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/