Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755120Ab2EELbX (ORCPT ); Sat, 5 May 2012 07:31:23 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:52518 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754683Ab2EELbV convert rfc822-to-8bit (ORCPT ); Sat, 5 May 2012 07:31:21 -0400 MIME-Version: 1.0 Reply-To: mtk.manpages@gmail.com In-Reply-To: <20120503141156.GP6871@ZenIV.linux.org.uk> References: <1335669917-23970-1-git-send-email-vapier@gentoo.org> <877gwxacti.fsf@skywalker.in.ibm.com> <87bom5xswc.fsf@skywalker.in.ibm.com> <20120503141156.GP6871@ZenIV.linux.org.uk> From: "Michael Kerrisk (man-pages)" Date: Sat, 5 May 2012 23:31:00 +1200 Message-ID: Subject: Re: [PATCH] open(2): document O_PATH To: Al Viro Cc: "Aneesh Kumar K.V" , Mike Frysinger , linux-man@vger.kernel.org, Richard Weinberger , lkml Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1141 Lines: 31 On Fri, May 4, 2012 at 2:11 AM, Al Viro wrote: > On Thu, May 03, 2012 at 07:34:35PM +0530, Aneesh Kumar K.V wrote: > >> I looked at dnotify_flush, they remove markers on an inode. >> But then it also checks for filp to match. So I am not sure >> whether skipping dnotify_flush for O_PATH descriptor have any impact. We >> can't use O_PATH descriptor for dnotify fcntl any way. So in >> dnotify_flush we will not match the filp. >> >> Viro, >> >> Any reason why we skip dnotify_flush ?? > > See your last sentence above - why bother finding the mark, scanning the > list, etc. when we know that there won't be any matches? So, am I correct to understand that O_PATH has no interaction with dnotify? Thanks, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Author of "The Linux Programming Interface"; http://man7.org/tlpi/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/