Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755452Ab2EGHlt (ORCPT ); Mon, 7 May 2012 03:41:49 -0400 Received: from LGEMRELSE1Q.lge.com ([156.147.1.111]:52207 "EHLO LGEMRELSE1Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754571Ab2EGHls (ORCPT ); Mon, 7 May 2012 03:41:48 -0400 X-AuditID: 9c93016f-b7c79ae0000006b3-99-4fa77cb5b1c6 From: Namhyung Kim To: Pekka Enberg Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Paul Mackerras , Ingo Molnar , LKML Subject: Re: [PATCH v2 2/2] perf ui/gtk: Use struct perf_error_ops References: <1336370582-30959-1-git-send-email-namhyung.kim@lge.com> <1336370582-30959-2-git-send-email-namhyung.kim@lge.com> Date: Mon, 07 May 2012 16:40:19 +0900 In-Reply-To: (Pekka Enberg's message of "Mon, 7 May 2012 10:17:41 +0300") Message-ID: <874nrssal8.fsf@sejong.aot.lge.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1188 Lines: 29 Hi, On Mon, 7 May 2012 10:17:41 +0300, Pekka Enberg wrote: > On Mon, May 7, 2012 at 9:03 AM, Namhyung Kim wrote: >> Define and use perf_gtk_eops to provide a GTK2 message >> dialog for error reporting. To do that, we need global >> main_window variable for tracking UI state. >> >> Signed-off-by: Namhyung Kim > > I still don't like the dialog-based approach because it requires the > *user* to respond. Just add a label to the GTK window and show the > latest message there. If you want to make it even prettier, make the > label clickable and open up a popup that shows all the warnings and > errors in a separate window... As I said before, most of calls to ui__warning/error are called just before the main window is closed or critical enough to require user's reponse - if not, it probably needs to use other API. So I think it's OK for the current symantics of the API. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/