Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755619Ab2EGIZX (ORCPT ); Mon, 7 May 2012 04:25:23 -0400 Received: from mga01.intel.com ([192.55.52.88]:40452 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755447Ab2EGIZV (ORCPT ); Mon, 7 May 2012 04:25:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="162820082" Date: Mon, 7 May 2012 11:26:37 +0300 From: Mika Westerberg To: Stephen Rothwell Cc: Anton Vorontsov , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux-next: build failure after merge of the final tree (battery tree related) Message-ID: <20120507082637.GH31494@intel.com> References: <20120507171458.5ce17d20c40856e9440b3e5f@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120507171458.5ce17d20c40856e9440b3e5f@canb.auug.org.au> Organization: Intel Finland Oy - BIC 0357606-4 - PL 281, 00181 Helsinki User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2137 Lines: 52 On Mon, May 07, 2012 at 05:14:58PM +1000, Stephen Rothwell wrote: > > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/power/smb347-charger.c: In function 'smb347_probe': > drivers/power/smb347-charger.c:1039:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration] > drivers/power/smb347-charger.c:1040:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration] > > Caused by commit 34298d40e585 ("smb347-charger: Convert to regmap API"). I'm unable to reproduce this on x86 build. I guess gets included implicitly there. Patch below should fix this. Anton, care to pick this one as well (or fold it into the 34298d40e585 ("smb347-charger: Convert to regmap API") commit)? From: Mika Westerberg Subject: [PATCH] smb347-charger: include missing Without the include we get build errors like: drivers/power/smb347-charger.c: In function 'smb347_probe': drivers/power/smb347-charger.c:1039:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration] drivers/power/smb347-charger.c:1040:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration] Reported-by: Stephen Rothwell Signed-off-by: Mika Westerberg --- drivers/power/smb347-charger.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/power/smb347-charger.c b/drivers/power/smb347-charger.c index 09d19d2..f8eedd8 100644 --- a/drivers/power/smb347-charger.c +++ b/drivers/power/smb347-charger.c @@ -11,6 +11,7 @@ * published by the Free Software Foundation. */ +#include #include #include #include -- 1.7.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/