Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755777Ab2EGIkX (ORCPT ); Mon, 7 May 2012 04:40:23 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:41415 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755544Ab2EGIkV (ORCPT ); Mon, 7 May 2012 04:40:21 -0400 Date: Mon, 7 May 2012 10:40:16 +0200 From: Ingo Molnar To: Namhyung Kim Cc: Pekka Enberg , Arnaldo Carvalho de Melo , Peter Zijlstra , Paul Mackerras , Ingo Molnar , LKML Subject: Re: [PATCH 7/7] perf ui/gtk: Use struct perf_error_ops Message-ID: <20120507084015.GL16608@gmail.com> References: <1335761711-31403-1-git-send-email-namhyung.kim@lge.com> <1335761711-31403-8-git-send-email-namhyung.kim@lge.com> <87ipghsjsk.fsf@sejong.aot.lge.com> <20120507081051.GD16608@gmail.com> <87zk9kqtwh.fsf@sejong.aot.lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zk9kqtwh.fsf@sejong.aot.lge.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2577 Lines: 67 * Namhyung Kim wrote: > Hi, > > On Mon, 7 May 2012 10:10:51 +0200, Ingo Molnar wrote: > > * Namhyung Kim wrote: > > > >> Hi, > >> > >> On Mon, 30 Apr 2012 09:31:28 +0300 (EEST), Pekka Enberg wrote: > >> > On Mon, 30 Apr 2012, Namhyung Kim wrote: > >> >> Define and use perf_gtk_eops to provide a GTK2 message > >> >> dialog for error reporting. To do that, we need global > >> >> main_window variable for tracking UI state. > >> >> > >> > I think this is an usability glitch waiting to happen - especially so if > >> > you use it for warnings. There's no reason to require the user to react to > >> > warning messages in the GUI because there's absolutely nothing they can do > >> > about them. > >> > > >> > I guess we could do something like the "ui helpline" thing used by the > >> > newt front-end if we really wanted to. > >> > > >> > Pekka > >> > >> I did quick grep on ui__warning and found that most of its > >> users are trying to show the messages before exiting. I think > >> some (at least) of them can be converted to ui__error(). And > >> as existing implementation (TUI) already requires user input > >> for this, I thought it's ok. > >> > >> But I agreed with you that ui__warning should not be used for > >> showing non-critical messages and converted to helpline-style > >> ones. > > > > If they are in essence ui__error() already then please convert > > them to ui__error() instead of perpetuating the mistake - don't > > force annoying pop-ups for warnings that may or may not be > > fatal. Spurious pop-ups are sad and people hate them. > > > > Ok, will do that in another patch (series). So you mean > ui__warning should not be a pop-up dialog, right? Pekka, is that what you meant too? If there are *real* warnings that are not followed up by some fatal close of the application then those should probably be displayed in some sort of unintrusive manner - a scrolling list of events, a small status display box that can be clicked on if people get curious, etc. Small, well-thought out details like that are nice in a GUI. Create enough of them and people start not to hate the app (people generally hate computers, so GUIs have an uphill struggle). Break a critical mass and people will actively love the app. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/