Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755747Ab2EGLBI (ORCPT <rfc822;w@1wt.eu>);
	Mon, 7 May 2012 07:01:08 -0400
Received: from casper.infradead.org ([85.118.1.10]:55782 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752084Ab2EGLBH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 7 May 2012 07:01:07 -0400
Subject: Re: [PATCH 3/7] perf tools: Add parser for dynamic PMU events
From: Peter Zijlstra <peterz@infradead.org>
To: Robert Richter <robert.richter@amd.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>, Ingo Molnar <mingo@kernel.org>,
        Stephane Eranian <eranian@google.com>, Jiri Olsa <jolsa@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>
In-Reply-To: <1335983192-23731-4-git-send-email-robert.richter@amd.com>
References: <1335983192-23731-1-git-send-email-robert.richter@amd.com>
	 <1335983192-23731-4-git-send-email-robert.richter@amd.com>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 07 May 2012 13:01:03 +0200
Message-ID: <1336388463.27020.3.camel@laptop>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.2 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 755
Lines: 21

On Wed, 2012-05-02 at 20:26 +0200, Robert Richter wrote:
> This patch adds support for pmu specific event parsers by extending
> the pmu handler. The event syntax is the same as for tracepoints:
> 
>  <subsys>:<name>:<modifier> 

I really don't like this

> -          event_legacy_tracepoint sep_dc |
> +          event_legacy_generic sep_dc |

That 'legacy' in there is a good hint you shouldn't be using this.

Ideally I'd get rid of all legacy formats eventually, we really
shouldn't be adding new ones. 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/