Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756471Ab2EGMKQ (ORCPT ); Mon, 7 May 2012 08:10:16 -0400 Received: from na3sys009aog113.obsmtp.com ([74.125.149.209]:49006 "EHLO na3sys009aog113.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755941Ab2EGMKO (ORCPT ); Mon, 7 May 2012 08:10:14 -0400 Message-ID: <1336392608.11901.0.camel@odin> Subject: Re: [PATCH] regulator: Actually free the regulator in devm_regulator_put() From: Liam Girdwood To: Mark Brown Cc: linux-kernel@vger.kernel.org Date: Mon, 07 May 2012 13:10:08 +0100 In-Reply-To: <1336390862-22479-1-git-send-email-broonie@opensource.wolfsonmicro.com> References: <1336390862-22479-1-git-send-email-broonie@opensource.wolfsonmicro.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 734 Lines: 17 On Mon, 2012-05-07 at 12:41 +0100, Mark Brown wrote: > It turns out that (quite surprisingly) devres_destroy() only undoes the > devres mapping, it doesn't destroy the underlying resource, meaning that > anything using devm_regulator_put() would leak. While we wait for the new > devres_release() which does what we want to get merged open code it in > devm_regulator_put(). > > Signed-off-by: Mark Brown > --- Acked-by: Liam Girdwood -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/