Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757032Ab2EGPDO (ORCPT ); Mon, 7 May 2012 11:03:14 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:52390 "EHLO e38.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756806Ab2EGPDN (ORCPT ); Mon, 7 May 2012 11:03:13 -0400 Message-ID: <4FA7E3D0.2040906@linux.vnet.ibm.com> Date: Mon, 07 May 2012 10:01:36 -0500 From: Seth Jennings User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Minchan Kim CC: Nitin Gupta , Greg Kroah-Hartman , Dan Magenheimer , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Konrad Rzeszutek Wilk Subject: Re: [PATCH 3/4] zsmalloc use zs_handle instead of void * References: <1336027242-372-1-git-send-email-minchan@kernel.org> <1336027242-372-3-git-send-email-minchan@kernel.org> <4FA28907.9020300@vflare.org> <4FA2A2F0.3030509@linux.vnet.ibm.com> <4FA33DF6.8060107@kernel.org> In-Reply-To: <4FA33DF6.8060107@kernel.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12050715-5518-0000-0000-000004352BB7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1007 Lines: 36 On 05/03/2012 09:24 PM, Minchan Kim wrote: > On 05/04/2012 12:23 AM, Seth Jennings wrote: >> The reason I hadn't done it before is that it introduces a checkpatch >> warning: >> >> WARNING: do not add new typedefs >> #303: FILE: drivers/staging/zsmalloc/zsmalloc.h:19: >> +typedef void * zs_handle; >> > > > Yes. I did it but I think we are (a) of chapter 5: Typedefs in Documentation/CodingStyle. > > (a) totally opaque objects (where the typedef is actively used to _hide_ > what the object is). > > No? Interesting, seems like checkpatch and CodingStyle aren't completely in sync here. Maybe the warning should say "do not add new typedefs unless allowed by CodingStyle 5(a)" or something. Works for me though. Thanks again Minchan! -- Seth -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/