Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756921Ab2EGP7I (ORCPT ); Mon, 7 May 2012 11:59:08 -0400 Received: from va3ehsobe003.messaging.microsoft.com ([216.32.180.13]:59913 "EHLO va3outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756571Ab2EGP7G (ORCPT ); Mon, 7 May 2012 11:59:06 -0400 X-SpamScore: -12 X-BigFish: VPS-12(zz936eK1432N98dKzz1202hzzz2dh668h839h944hd25h) X-Forefront-Antispam-Report: CIP:163.181.249.109;KIP:(null);UIP:(null);IPV:NLI;H:ausb3twp02.amd.com;RD:none;EFVD:NLI X-WSS-ID: 0M3NTQA-02-6DC-02 X-M-MSG: Date: Mon, 7 May 2012 17:58:55 +0200 From: Robert Richter To: Peter Zijlstra CC: Arnaldo Carvalho de Melo , Ingo Molnar , Stephane Eranian , Jiri Olsa , LKML Subject: Re: [PATCH 4/7] perf/x86-ibs: Add support for IBS pseudo events Message-ID: <20120507155855.GJ18810@erda.amd.com> References: <1335983192-23731-1-git-send-email-robert.richter@amd.com> <1335983192-23731-5-git-send-email-robert.richter@amd.com> <1336395782.27020.37.camel@laptop> <20120507154412.GH18810@erda.amd.com> <1336405911.27020.70.camel@laptop> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1336405911.27020.70.camel@laptop> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: amd.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1542 Lines: 38 On 07.05.12 17:51:51, Peter Zijlstra wrote: > On Mon, 2012-05-07 at 17:44 +0200, Robert Richter wrote: > > On 07.05.12 15:03:02, Peter Zijlstra wrote: > > > On Wed, 2012-05-02 at 20:26 +0200, Robert Richter wrote: > > > > +enum ibs_filter_type { > > > > + IBS_NO_FILTER = 0, > > > > + IBS_MATCH_FILTER = 1, > > > > + IBS_ANY_SET_FILTER = 2, > > > > + IBS_PSEUDO_EVENT = 0x0F, > > > > +}; > > > > > > I don't get how those pseudo events work, AFAIKT IBS_PSEUDO_EVENT causes > > > one to loose all events since it does have a filter set but fails the > > > filter and thus we skip the call to perf_event_overflow(). > > > > You periodically (fix clk cycles or number of micro-ops) trigger IBS > > samples and afterwards analyses the samples for certain filter rules > > (see rule description in pmu-ibs.c). > > But IBS_PSEUDO_EVENT will fail all filter test and you'll end up with > exactly 0 samples. Still somewhat confused.. Ahh, got your question. This is a place holder for writing the pseudo event id's (0xF000 mask) directly in config[12]. But this is not yet implemented. And since we probably all prefer userland filtering we just don't need this at all. -Robert -- Advanced Micro Devices, Inc. Operating System Research Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/