Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757509Ab2EGQ4g (ORCPT ); Mon, 7 May 2012 12:56:36 -0400 Received: from mga09.intel.com ([134.134.136.24]:19926 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757447Ab2EGQ4C (ORCPT ); Mon, 7 May 2012 12:56:02 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.67,352,1309762800"; d="scan'208";a="137865915" From: Artem Bityutskiy To: David Woodhouse , MTD Maling List Cc: Linux Kernel Maling List Subject: [PATCH v2 3/4] jffs2: remove unnecessary GC pass on sync Date: Mon, 7 May 2012 19:56:52 +0300 Message-Id: <1336409813-6365-4-git-send-email-dedekind1@gmail.com> X-Mailer: git-send-email 1.7.7.6 In-Reply-To: <1336409813-6365-1-git-send-email-dedekind1@gmail.com> References: <1336409813-6365-1-git-send-email-dedekind1@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1252 Lines: 38 From: Artem Bityutskiy We do not need to call 'jffs2_write_super()' on sync. This function causes a GC pass to make sure the current contents is pushed out with the data which we already have on the media. But this is not needed on unmount and only slows sync down unnecessarily. It is enough to just sync the write-buffer. This call was added by one of the generic VFS rework patch-sets, see d579ed00aa96a7f7486978540a0d7cecaff742ae. Signed-off-by: Artem Bityutskiy --- fs/jffs2/super.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c index d3dc9d8..dc366c0 100644 --- a/fs/jffs2/super.c +++ b/fs/jffs2/super.c @@ -110,8 +110,6 @@ static int jffs2_sync_fs(struct super_block *sb, int wait) { struct jffs2_sb_info *c = JFFS2_SB_INFO(sb); - jffs2_write_super(sb); - mutex_lock(&c->alloc_sem); jffs2_flush_wbuf_pad(c); mutex_unlock(&c->alloc_sem); -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/