Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757482Ab2EGRIt (ORCPT ); Mon, 7 May 2012 13:08:49 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:51987 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756571Ab2EGRIr (ORCPT ); Mon, 7 May 2012 13:08:47 -0400 Date: Mon, 7 May 2012 10:08:40 -0700 From: Tejun Heo To: Michal Hocko Cc: Hiroyuki Kamezawa , David Rientjes , "Aneesh Kumar K.V" , Andrew Morton , Randy Dunlap , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Weinberger , KAMEZAWA Hiroyuki , Johannes Weiner Subject: Re: inux-next: Tree for Apr 27 (uml + mm/memcontrol.c) Message-ID: <20120507170840.GA19417@google.com> References: <20120427132343.fbb443b9.akpm@linux-foundation.org> <20120427143646.8209627e.akpm@linux-foundation.org> <87fwbnag6u.fsf@skywalker.in.ibm.com> <20120504172420.GF24639@google.com> <20120507140103.GA4251@tiehlicka.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120507140103.GA4251@tiehlicka.suse.cz> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1073 Lines: 27 Hello, On Mon, May 07, 2012 at 04:01:04PM +0200, Michal Hocko wrote: > > If someone really has to add cgroup support to hugetlbfs, I'm more > > inclined to say let them play in their own corner unless incorporating > > it into memcg makes it inherently better. > > I would agree with you but my impression from the previous (hugetlb) > implementation was that it is much harder to implement the charge moving > if we do not use page_cgroup. > Also the range tracking is rather ugly and clumsy. Understood. I haven't looked at the code, so my opinion was based on the assumption that the whole thing is completely separate (in design and implementation) from memcg as hugtlbfs is from the usual mm. If it's better / easier implemented together with memcg, I have no objection to making it part of memcg. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/