Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757757Ab2EGUUU (ORCPT ); Mon, 7 May 2012 16:20:20 -0400 Received: from mail-vb0-f46.google.com ([209.85.212.46]:59687 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757622Ab2EGUUT convert rfc822-to-8bit (ORCPT ); Mon, 7 May 2012 16:20:19 -0400 MIME-Version: 1.0 In-Reply-To: References: <1336321508-20981-1-git-send-email-krzysztof.wilczynski@linux.com> From: Krzysztof Wilczynski Date: Mon, 7 May 2012 21:19:38 +0100 X-Google-Sender-Auth: dEcY3lcwb9zS66Hus9pW1Jf-f5Y Message-ID: Subject: Re: [PATCH] gpio: langwell: Prevent possible NULL pointer dereference in the demux handler. To: Thomas Gleixner Cc: Grant Likely , Linus Walleij , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 748 Lines: 22 Hi, [...] >> -     chip->irq_eoi(data); >> +     if (data) >> +             chip->irq_eoi(data); > > And how does data, which is always set as long as the interrupt exist > prove that the chip has an eoi function? It won't, a very good point. And as you told me (IRC) this has to be solved on a more generic level (core handlers), and possibly abstracted from the drivers. I will do and read through the code of core handlers to learn more. Thanks for pointing it out and help so far :) KW -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/