Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753585Ab2EGXjn (ORCPT ); Mon, 7 May 2012 19:39:43 -0400 Received: from na3sys009aog108.obsmtp.com ([74.125.149.199]:56379 "EHLO na3sys009aog108.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753340Ab2EGXjl convert rfc822-to-8bit (ORCPT ); Mon, 7 May 2012 19:39:41 -0400 From: Kevin Hilman To: "J\, KEERTHY" Cc: "AnilKumar\, Chimata" , "linux-omap\@vger.kernel.org" , "linux-arm-kernel\@lists.infradead.org" , "rjw\@sisk.pl" , "linux-kernel\@vger.kernel.org" , "linux-pm\@lists.linux-foundation.org" , "Pihet-XID\, Jean" Subject: Re: [PATCH V3 04/10] ARM: OMAP3: hwmod: rename the smartreflex entries Organization: Texas Instruments, Inc. References: <1335462041-4949-1-git-send-email-j-keerthy@ti.com> <1335462041-4949-5-git-send-email-j-keerthy@ti.com> <331ABD5ECB02734CA317220B2BBEABC13E9B1AA2@DBDE01.ent.ti.com> Date: Mon, 07 May 2012 16:39:53 -0700 In-Reply-To: (KEERTHY J.'s message of "Fri, 4 May 2012 15:41:34 +0530") Message-ID: <87d36fzhkm.fsf@ti.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3817 Lines: 88 "J, KEERTHY" writes: > Hi AnilKumar, > > Thanks for reviewing. > > On Fri, May 4, 2012 at 2:00 PM, AnilKumar, Chimata wrote: >> On Thu, Apr 26, 2012 at 23:10:35, J, KEERTHY wrote: >>> From: Jean Pihet >>> >>> Change the name field value to better reflect the smartreflex >>> integration in the system. >>> >>> Signed-off-by: Jean Pihet >>> Signed-off-by: J Keerthy >>> --- >>>  arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |    8 ++++---- >>>  arch/arm/mach-omap2/smartreflex.c          |    2 +- >>>  2 files changed, 5 insertions(+), 5 deletions(-) >>> >>> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c >>> index 144d118..15907b0 100644 >>> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c >>> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c >>> @@ -1324,7 +1324,7 @@ static struct omap_hwmod_irq_info omap3_smartreflex_mpu_irqs[] = { >>>  }; >>> >>>  static struct omap_hwmod omap34xx_sr1_hwmod = { >>> -     .name           = "sr1", >>> +     .name           = "smartreflex_mpu_iva", >>>       .class          = &omap34xx_smartreflex_hwmod_class, >>>       .main_clk       = "sr1_fck", >>>       .prcm           = { >>> @@ -1342,7 +1342,7 @@ static struct omap_hwmod omap34xx_sr1_hwmod = { >>>  }; >>> >>>  static struct omap_hwmod omap36xx_sr1_hwmod = { >>> -     .name           = "sr1", >>> +     .name           = "smartreflex_mpu_iva", >>>       .class          = &omap36xx_smartreflex_hwmod_class, >>>       .main_clk       = "sr1_fck", >>>       .prcm           = { >>> @@ -1369,7 +1369,7 @@ static struct omap_hwmod_irq_info omap3_smartreflex_core_irqs[] = { >>>  }; >>> >>>  static struct omap_hwmod omap34xx_sr2_hwmod = { >>> -     .name           = "sr2", >>> +     .name           = "smartreflex_core", >>>       .class          = &omap34xx_smartreflex_hwmod_class, >>>       .main_clk       = "sr2_fck", >>>       .prcm           = { >>> @@ -1387,7 +1387,7 @@ static struct omap_hwmod omap34xx_sr2_hwmod = { >>>  }; >>> >>>  static struct omap_hwmod omap36xx_sr2_hwmod = { >>> -     .name           = "sr2", >>> +     .name           = "smartreflex_core", >>>       .class          = &omap36xx_smartreflex_hwmod_class, >>>       .main_clk       = "sr2_fck", >>>       .prcm           = { >>> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c >>> index 2edd1e2..d859277 100644 >>> --- a/arch/arm/mach-omap2/smartreflex.c >>> +++ b/arch/arm/mach-omap2/smartreflex.c >>> @@ -183,7 +183,7 @@ static void sr_set_regfields(struct omap_sr *sr) >>>               sr->err_weight = OMAP3430_SR_ERRWEIGHT; >>>               sr->err_maxlimit = OMAP3430_SR_ERRMAXLIMIT; >>>               sr->accum_data = OMAP3430_SR_ACCUMDATA; >>> -             if (!(strcmp(sr->name, "sr1"))) { >>> +             if (!(strcmp(sr->name, "smartreflex_mpu_iva"))) { >> >> What if voltage rail is different for mpu and iva? I have seen some devices >> supports SmartReflex have different voltage rails for mpu and iva. >> > > I get the point. OMAP3 iva and mpu have a common rail. OMAP4 onwards > even we have different rails for mpu and iva. I will enhance the checks here. Rather than enhancing the checks, this SoC specific data should probably just be made part of the SoC specific hwmod dev_attr. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/