Date: Tue, 8 May 2012 10:15:49 +0200
From: Manohar Vanga <manohar.vanga@cern.ch>
To: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>,
        Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v3 2/3] Staging: ipack: added support for the TEWS
 TPCI-200 carrier board
Message-ID: <20120508081549.GB18595@becoht-mvanga>
Mail-Followup-To: Samuel Iglesias Gonsalvez <siglesias@igalia.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Dan Carpenter <dan.carpenter@oracle.com>
References: <1336463005-26234-1-git-send-email-siglesias@igalia.com>
 <1336463005-26234-2-git-send-email-siglesias@igalia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1336463005-26234-2-git-send-email-siglesias@igalia.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Keywords: CERN SpamKiller Note: -50
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 916
Lines: 29

Hey Samuel,

> +static void tpci200_uninstall(struct tpci200_board *tpci200)
> +{
> +	int i;
> +
> +	for (i = 0; i < TPCI200_NB_SLOT; i++) {
> +		if (tpci200->slots[i].dev == NULL)
> +			continue;
> +		else
> +			tpci200->slots[i].dev->driver->ops->remove(tpci200->slots[i].dev);

Check whether the function exists or you could have trouble :)
If you already added a check when registering to make sure this is always non-NULL then
ignore this. I would recommend wrapping this up in some function:

    void tpci_slot_remove(struct tpci_slot *slot)
    {
        if (slot->dev->driver->ops->remove)
        	slot->dev->driver->ops->remove(slot->dev);
    }

-- 
/manohar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/