Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754127Ab2EHKTL (ORCPT ); Tue, 8 May 2012 06:19:11 -0400 Received: from cpsmtpb-ews02.kpnxchange.com ([213.75.39.5]:3700 "EHLO cpsmtpb-ews02.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753089Ab2EHKTJ (ORCPT ); Tue, 8 May 2012 06:19:09 -0400 Message-ID: <1336472346.1933.52.camel@x61.thuisdomein> Subject: [PATCH 0/3] scsi: usb-storage: hide errors for five devices From: Paul Bolle To: "James E.J. Bottomley" , Matthew Dharm , Greg Kroah-Hartman Cc: linux-scsi@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 08 May 2012 12:19:06 +0200 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3 (3.2.3-3.fc16) Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-OriginalArrivalTime: 08 May 2012 10:19:07.0141 (UTC) FILETIME=[00476350:01CD2D04] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1524 Lines: 42 0) Five USB memory sticks I happen to have will generate sets of two errors when inserted. These sets are either: [...] Asking for cache data failed [...] Assuming drive cache: write through or: [...] No Caching mode page present [...] Assuming drive cache: write through These errors are generated by the SCSI stack (and printed thrice). 1) These patches try to hide those errors by: - downgrading one error to a notice; and - setting the NO_WP_DETECT quirk for these five devices. 2) Review of these patches is appreciated. Please note that the first patch downgrades the error also for code paths that I apparently never trigger, so that one especially needs additional thought, testing, etc. 3) It's not entirely clear which names one should use in the UNUSUAL_DEV() macro. I just picked the most neutral names that showed up for the devices in the logs. 4) Tested on v3.3.4, but applies cleanly to v3.4-rc6. Paul Bolle (3): scsi: downgrade "write through" error to notice usb-storage: use NO_WP_DETECT for two devices usb-storage: use NO_WP_DETECT for three devices drivers/scsi/sd.c | 2 +- drivers/usb/storage/unusual_devs.h | 22 ++++++++++++++++++++-- 2 files changed, 21 insertions(+), 3 deletions(-) -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/