Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755451Ab2EHOCe (ORCPT ); Tue, 8 May 2012 10:02:34 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:38146 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755110Ab2EHOCc (ORCPT ); Tue, 8 May 2012 10:02:32 -0400 Date: Tue, 8 May 2012 10:02:31 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Paul Bolle cc: "James E.J. Bottomley" , Matthew Dharm , Greg Kroah-Hartman , , , , Subject: Re: [PATCH 0/3] scsi: usb-storage: hide errors for five devices In-Reply-To: <1336472346.1933.52.camel@x61.thuisdomein> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1067 Lines: 31 On Tue, 8 May 2012, Paul Bolle wrote: > 0) Five USB memory sticks I happen to have will generate sets of two > errors when inserted. These sets are either: > [...] Asking for cache data failed > [...] Assuming drive cache: write through > > or: > [...] No Caching mode page present > [...] Assuming drive cache: write through > > These errors are generated by the SCSI stack (and printed thrice). > > 1) These patches try to hide those errors by: > - downgrading one error to a notice; and That's a reasonable thing to do, IMO. > - setting the NO_WP_DETECT quirk for these five devices. But that isn't. These quirks are intended for devices that crash when they receive the command in question. They aren't meant to suppress sending commands to devices that can properly reject them. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/