Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755611Ab2EHO3d (ORCPT ); Tue, 8 May 2012 10:29:33 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:56055 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755278Ab2EHO3c (ORCPT ); Tue, 8 May 2012 10:29:32 -0400 MIME-Version: 1.0 In-Reply-To: References: <1336004953.4240.9.camel@mop> <1336475689.1179.12.camel@mop> From: Kay Sievers Date: Tue, 8 May 2012 16:29:11 +0200 Message-ID: Subject: Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer To: Sasha Levin Cc: Greg Kroah-Hartmann , Linus Torvalds , Ingo Molnar , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1779 Lines: 44 On Tue, May 8, 2012 at 3:33 PM, Sasha Levin wrote: > On Tue, May 8, 2012 at 1:14 PM, Kay Sievers wrote: > The 3rd one actually looks like the KERN_CONT problem now that you've > explained it. You can see it in the 'saved trace' test in the boot > log. > > I've attached the boot log which shows several other places with this > issue, The percpu stuff should be pending (thought it was in -next already): https://lkml.org/lkml/2012/3/29/317 The ACPI stuff was fixed here: https://lkml.org/lkml/2012/4/2/532 But only the vt and hpet things got merged so far: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=5da527aafed2834852fc4fe21daeaeadf7c61af3 I'll respin the ACPI parts now. > if you're ok with it I can try patching those myself. That would be awesome. If you decide otherwise, please let me know, and I'll take care of them. Even if we decide to relax the current strict behaviour later, we should fix all stuff we run into. Userspace really relies on proper messages, and not partial or mixed up things to guess what they mean. The nice thing with the currently strict logic is that only two instances of KERN_CONT running at the same time can race against each other and mix their own messages. Unlike the old kmsg behaviour, users which log a single proper terminated line, will never get interleaved with the KERN_CONT users. This reduces the "risk" of garbled messages to the users which actually decided to take this "risk". Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/