Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757029Ab2EHQLw (ORCPT ); Tue, 8 May 2012 12:11:52 -0400 Received: from hqemgate04.nvidia.com ([216.228.121.35]:9524 "EHLO hqemgate04.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756145Ab2EHQLv (ORCPT ); Tue, 8 May 2012 12:11:51 -0400 X-PGP-Universal: processed; by hqnvupgp05.nvidia.com on Tue, 08 May 2012 09:11:46 -0700 Subject: Re: [PATCH 5/6 v3] mfd: tps65910-irq: Add devicetree init support From: Rhyland Klein To: Mark Brown Cc: Samuel Ortiz , Grant Likely , Rob Herring , Liam Girdwood , "linux-kernel@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" In-Reply-To: <20120508154820.GA15893@opensource.wolfsonmicro.com> References: <1336502563-31789-1-git-send-email-rklein@nvidia.com> <1336502563-31789-6-git-send-email-rklein@nvidia.com> <20120508154820.GA15893@opensource.wolfsonmicro.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 08 May 2012 12:11:31 -0700 Message-ID: <1336504291.31930.24.camel@rklein-linux> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1252 Lines: 42 On Tue, 2012-05-08 at 08:48 -0700, Mark Brown wrote: > * PGP Signed by an unknown key > > On Tue, May 08, 2012 at 11:42:42AM -0700, Rhyland Klein wrote: > > > + if (pdata->irq_base <= 0) > > + pdata->irq_base = irq_alloc_descs(-1, 0, tps65910->irq_num, -1); > > + > > + if (pdata->irq_base <= 0) { > > + dev_err(tps65910->dev, "Failed to allocate irq descs: %d\n", > > + pdata->irq_base); > > + return pdata->irq_base; > > + } > > I'd expect the driver to always call irq_alloc_descs() but to use the > value specified in platform data if there is any. This is the normal > way of doing things, anyway. > Is this more what you would expect? If the dt code initialized the irq_base to 0 instead of -1 then this should also work. pdata->irq_base = irq_alloc_descs(-1, pdata->irq_base, tps65910->irq_num, -1); if (pdata->irq_base <= 0) { dev_err(tps65910->dev, "Failed to allocate irq descs: %d\n", pdata->irq_base); return pdata->irq_base; } > * Unknown Key > * 0x6E30FDDD -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/