Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755678Ab2EHQ2G (ORCPT ); Tue, 8 May 2012 12:28:06 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:36301 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753843Ab2EHQ2E (ORCPT ); Tue, 8 May 2012 12:28:04 -0400 MIME-Version: 1.0 In-Reply-To: References: <1336004953.4240.9.camel@mop> <1336475689.1179.12.camel@mop> From: Kay Sievers Date: Tue, 8 May 2012 18:27:42 +0200 Message-ID: Subject: Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer To: Sasha Levin Cc: Greg Kroah-Hartmann , Linus Torvalds , Ingo Molnar , linux-kernel@vger.kernel.org, Karel Zak Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1068 Lines: 23 On Tue, May 8, 2012 at 5:57 PM, Sasha Levin wrote: > What about PRINTK_TIME? Are there plans to enable it on console output? Yeah, we should restore the old behaviour. The timestamp is always stored internally, regardless of the CONFIG_PRINTK_TIME or tunable setting. At the moment, seems they are only (conditionally) added to the syslog() output and (unconditionally) to the /dev/kmsg export. I guess we just re-define CONFIG_PRINTK_TIME and the tunable as: "show time in syslog() and on the console output". Karel will likely extend dmesg(1) to use /dev/kmsg instead of syslog() when it's readable and dmesg(1) can still show the time stamps read from /dev/kmsg, even when CONFIG_PRINTK_TIME is not set, so the old tunable basically becomes a "show timestamps on the console" flag. :) Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/