Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756890Ab2EHQgn (ORCPT ); Tue, 8 May 2012 12:36:43 -0400 Received: from hqemgate04.nvidia.com ([216.228.121.35]:13600 "EHLO hqemgate04.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756027Ab2EHQgl (ORCPT ); Tue, 8 May 2012 12:36:41 -0400 X-PGP-Universal: processed; by hqnvupgp05.nvidia.com on Tue, 08 May 2012 09:36:35 -0700 Subject: Re: [PATCH 5/6 v3] mfd: tps65910-irq: Add devicetree init support From: Rhyland Klein To: Mark Brown Cc: Samuel Ortiz , Grant Likely , Rob Herring , Liam Girdwood , "linux-kernel@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" In-Reply-To: <20120508162901.GD15893@opensource.wolfsonmicro.com> References: <1336502563-31789-1-git-send-email-rklein@nvidia.com> <1336502563-31789-6-git-send-email-rklein@nvidia.com> <20120508154820.GA15893@opensource.wolfsonmicro.com> <1336504291.31930.24.camel@rklein-linux> <20120508162901.GD15893@opensource.wolfsonmicro.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 08 May 2012 12:36:18 -0400 Message-ID: <1336494978.31930.41.camel@rklein-linux> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1016 Lines: 38 On Tue, 2012-05-08 at 09:29 -0700, Mark Brown wrote: > * PGP Signed by an unknown key > > On Tue, May 08, 2012 at 12:11:31PM -0700, Rhyland Klein wrote: > > > Is this more what you would expect? If the dt code initialized the > > irq_base to 0 instead of -1 then this should also work. > > > pdata->irq_base = irq_alloc_descs(-1, pdata->irq_base, > > tps65910->irq_num, -1); > > if (pdata->irq_base <= 0) { > > dev_err(tps65910->dev, "Failed to allocate irq descs: %d\n", > > pdata->irq_base); > > return pdata->irq_base; > > } > > More like: > > if (pdata->irq_base) > base = pdata->irq_base; > else > base = 0; > pdata->irq_base = irq_alloc_descs(base, 0, Alright, will do in next round of changes. > > * Unknown Key > * 0x6E30FDDD -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/