Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754097Ab2EIDw3 (ORCPT ); Tue, 8 May 2012 23:52:29 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:64605 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752863Ab2EIDw2 (ORCPT ); Tue, 8 May 2012 23:52:28 -0400 MIME-Version: 1.0 In-Reply-To: <1336475689.1179.12.camel@mop> References: <1336004953.4240.9.camel@mop> <1336475689.1179.12.camel@mop> From: Linus Torvalds Date: Tue, 8 May 2012 20:52:06 -0700 X-Google-Sender-Auth: WjKsk4ejE7W_KgxrVW3wfGUKHjw Message-ID: Subject: Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer To: Kay Sievers Cc: Sasha Levin , Greg Kroah-Hartmann , Ingo Molnar , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1404 Lines: 37 On Tue, May 8, 2012 at 4:14 AM, Kay Sievers wrote: > > Yeah, we need to make sure, we never merge the (always racy) > continuation printk() users with (non-racy) non-continuation users. > Therefore KERN_CONT is required to suppress the newline and to merge the > content with the earlier non-newline-terminated printk() line. Why? I really think this is just a bug in the new code. KERN_CONT should not be needed if the previous printk didn't have a final "\n". We made it easier to use printk for a reason a few months ago. The new rules are: - If you have a KERN_, it *always* starts a new line, the obvious exception being KERN_CONT - the loglevels *only* matter at the start of the printk - so if you have '\n' embedded in a single printk, that changes nothing what-so-ever. It's not line-based. - if you didn't have a '\n', and don't have a loglevel, KERN_CONT is implied. Quite frankly, those three rules (a) make sense and (b) make things easy. Breaking them now is a bug. Please don't go adding ugly KERN_CONT when there really isn't any reason for it. Just fix the printk code you broke. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/