Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758050Ab2EIIEL (ORCPT ); Wed, 9 May 2012 04:04:11 -0400 Received: from mail-gg0-f174.google.com ([209.85.161.174]:51547 "EHLO mail-gg0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757901Ab2EIIEF convert rfc822-to-8bit (ORCPT ); Wed, 9 May 2012 04:04:05 -0400 MIME-Version: 1.0 In-Reply-To: References: <1336431315-29736-1-git-send-email-andi@firstfloor.org> From: KOSAKI Motohiro Date: Wed, 9 May 2012 04:03:43 -0400 Message-ID: Subject: Re: [PATCH] slab/mempolicy: always use local policy from interrupt context v3 To: David Rientjes Cc: Andi Kleen , linux-kernel@vger.kernel.org, Andi Kleen , penberg@kernel.org, cl@linux.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 791 Lines: 20 >> > + ? ? ? if (!in_interrupt() || !policy || policy->flags & MPOL_F_LOCAL) >> > ? ? ? ? ? ? ? ?return numa_node_id(); >> >> I think your patch is correct. but I don't like interrupt context >> dereference current task. >> It would be nice if we only see current->mempolicy when !in_interrupt. >> >> But this doesn't mean NAK anyway. >> >> ?Acked-by: KOSAKI Motohiro > > Sigh, this was acked by Christoph and KOSAKI when the logic is reversed > and does the exact opposite of what's intended? Ahhh, Good catch! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/