Message-ID: <3f7a217a08fd2c508576cbac8d26b017.squirrel@www.codeaurora.org>
In-Reply-To: <1336054995-22988-15-git-send-email-svenkatr@ti.com>
References: <1336054995-22988-1-git-send-email-svenkatr@ti.com>
    <1336054995-22988-15-git-send-email-svenkatr@ti.com>
Date: Wed, 9 May 2012 01:35:00 -0700 (PDT)
Subject: Re: [PATCH v2 14/16] mmc: block: Implement HPI invocation and 
     handling logic.
From: kdorfman@codeaurora.org
To: "Venkatraman S" <svenkatr@ti.com>
Cc: linux-mmc@vger.kernel.org, cjb@laptop.org, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org, linux-omap@vger.kernel.org,
        linux-kernel@vger.kernel.org, arnd.bergmann@linaro.org,
        alex.lemberg@sandisk.com, ilan.smith@sandisk.com, lporzio@micron.com,
        rmk+kernel@arm.linux.org.uk, "Venkatraman S" <svenkatr@ti.com>
User-Agent: SquirrelMail/1.4.17
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Importance: Normal
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 995
Lines: 30


> +static bool mmc_can_do_foreground_hpi(struct mmc_queue *mq,
> +			struct request *req, unsigned int thpi)
> +{
> +
> +	/*
> +	 * If some time has elapsed since the issuing of previous write
> +	 * command, or if the size of the request was too small, there's
> +	 * no point in preempting it. Check if it's worthwhile to preempt
> +	 */
> +	int time_elapsed = jiffies_to_msecs(jiffies -
> +			mq->mqrq_cur->mmc_active.mrq->cmd->started_time);
> +
> +	if (time_elapsed <= thpi)
> +			return true;
Some host controllers (or DMA) has possibility to get the byte count of
current transaction. It may be implemented as host api (similar to abort
ops). Then you have more accurate estimation of worthiness.

> +
> +	return false;
> +}

Thanks, Kostya

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/