Message-ID: <1336564330.2527.23.camel@twins>
Subject: Re: [PATCH] sched_groups are expected to be circular linked list,
 make it so right after allocation
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Jiang Liu <liuj97@gmail.com>, linux-kernel@vger.kernel.org,
        mingo@kernel.org, pjt@google.com, tglx@linutronix.de,
        seto.hidetoshi@jp.fujitsu.com
Date: Wed, 09 May 2012 13:52:10 +0200
In-Reply-To: <4FAA588B.5010404@redhat.com>
References: <1336559908-32533-1-git-send-email-imammedo@redhat.com>
	 <4FAA452A.1070909@gmail.com> <4FAA588B.5010404@redhat.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1042
Lines: 24

On Wed, 2012-05-09 at 13:44 +0200, Igor Mammedov wrote:
> This patch fixes only build_sched_groups path, but there is another fail path
> that results in below OOPS.
> build_overlap_sched_groups() may exit without setting groups and later it will crash
> init_sched_groups_power as well.

if that allocation fails? Or is there another fail path?

>  But I just don't know how to fix it, so I've just
> posted partial fix that reduces crash frequency. 


> And I have to admit that
> cpu_active_mask and siblings map are busted but we either should not exit from builder
> funcs with NULL group or BUG there if it is impossible to come-up with sane group
> for insane domain span. 

I'm perfectly OK with taking the machine down, provided we can output
useful messages as to what is broken first..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/