Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760075Ab2EIQCM (ORCPT ); Wed, 9 May 2012 12:02:12 -0400 Received: from nat28.tlf.novell.com ([130.57.49.28]:50847 "EHLO nat28.tlf.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756451Ab2EIQCK convert rfc822-to-8bit (ORCPT ); Wed, 9 May 2012 12:02:10 -0400 Message-Id: <4FAAB134020000780008294F@nat28.tlf.novell.com> X-Mailer: Novell GroupWise Internet Agent 12.0.0 Date: Wed, 09 May 2012 17:02:28 +0100 From: "Jan Beulich" To: "Bjorn Helgaas" Cc: , , "Jesse Barnes" Subject: Re: [PATCH 1/5, resend] PCI: adjust quirk handler section annotations References: <4FAA4A5A0200007800082702@nat28.tlf.novell.com> In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1398 Lines: 33 >>> On 09.05.12 at 17:54, Bjorn Helgaas wrote: > On Wed, May 9, 2012 at 1:43 AM, Jan Beulich wrote: >> This is in preparation to adjust modpost to check section mismatches >> on most of the .pci_fixup* sections: >> >> .pci_fixup_final is only used from .init.text, and hence can (along >> with the respective handler functions) reside in .init.*. > > pci_apply_final_quirks() is currently __init, so this probably > wouldn't break anything. But the fact that it's all __init means > that pci_fixup_final quirks are only run for devices present at boot, > and they don't apply to hot-added devices. That seems like a bug to > me. > >> Several other .pci_fixup_* sections are needed only during boot and >> suspend/resume, and can therefore be moved into .init.* if >> !CONFIG_PM. > > My inclination is that all PCI fixups should work the same for > hot-added devices as for those present at boot, which would suggest > that we should always use __devinit, not __init. If I'm missing > something, please educate me :) That's certainly possible - I simply based the patch on what is there currently. Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/