Subject: Re: [PATCH 1/2] kconfig: change config_enabled() to accept X
 instead of CONFIG_X
From: Suresh Siddha <suresh.b.siddha@intel.com>
Reply-To: Suresh Siddha <suresh.b.siddha@intel.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: mingo@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org,
        torvalds@linux-foundation.org, joerg.roedel@amd.com,
        paul.gortmaker@windriver.com
Date: Wed, 09 May 2012 12:29:01 -0700
In-Reply-To: <20120509185608.GA13435@merkur.ravnborg.org>
References: <20120509093001.GD8585@gmail.com>
	 <1336589196-14498-1-git-send-email-suresh.b.siddha@intel.com>
	 <20120509185608.GA13435@merkur.ravnborg.org>
Organization: Intel Corp
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Message-ID: <1336591741.4634.4.camel@sbsiddha-desk.sc.intel.com>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 838
Lines: 27

On Wed, 2012-05-09 at 20:56 +0200, Sam Ravnborg wrote:
> On Wed, May 09, 2012 at 11:46:35AM -0700, Suresh Siddha wrote:
> > change config_enabled() to use it as config_enabled(SMP) instead of
> > config_enabled(CONFIG_SMP).
> 
> You are breaking all existing users.

I checked the mainline and there were no users as far as I checked.
Referring to some upcoming code? Just curious to see why I missed.

> And CONFIG_ was included to allow better grepability.

Ok.

> If you insist on having a CONFIG less variant
> introduce a new variant for this.

I will drop this for now.

thanks,
suresh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/