Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760910Ab2EITvT (ORCPT ); Wed, 9 May 2012 15:51:19 -0400 Received: from smtprelay-b12.telenor.se ([62.127.194.21]:52109 "EHLO smtprelay-b12.telenor.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754439Ab2EITvR (ORCPT ); Wed, 9 May 2012 15:51:17 -0400 X-SENDER-IP: [85.230.168.62] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Asm4AInJqk9V5qg+PGdsb2JhbABEijemZwF3AwGBIhkBAQEBHhkNJ4IMAQEEATocEwEPEAgDRhQlChoTiAkJvAETizyBa4MBYwSVfIYGjSc X-IronPort-AV: E=Sophos;i="4.75,559,1330902000"; d="scan'208";a="113460849" From: "Henrik Rydberg" Date: Wed, 9 May 2012 21:56:32 +0200 To: Benjamin Tissoires Cc: Dmitry Torokhov , Jiri Kosina , Stephane Chatty , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] HID: hid-multitouch: fix wrong protocol detection Message-ID: <20120509195632.GA12406@polaris.bitmath.org> References: <1336136030-18503-1-git-send-email-benjamin.tissoires@gmail.com> <1336136030-18503-2-git-send-email-benjamin.tissoires@gmail.com> <20120506190146.GA12571@polaris.bitmath.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 806 Lines: 21 > > Why not skip the pointer here? > > well, the idea was to keep the memory footprint low. As these values > are only needed at init, then I freed them once I finished using them. > I can of course skip the pointer, but in that case, wouldn't the > struct declaration be worthless? My bad, I misread the placement of the free() statement. I was also concerned about memory, since HID is big enough a memory hog as it is. Barring the added complexity of this patch, it now makes more sense. Acked-by: Henrik Rydberg Thanks, Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/