Date: Wed, 9 May 2012 13:39:16 -0700
From: Greg KH <gregkh@linuxfoundation.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, devel@driverdev.osuosl.org,
        fmhess@users.sourceforge.net, abbotti@mev.co.uk
Subject: Re: [PATCH v2] staging: comedi: refactor sysfs files in comedi_fops.c
Message-ID: <20120509203916.GA16972@kroah.com>
References: <201205090920.09769.hartleys@visionengravers.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201205090920.09769.hartleys@visionengravers.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1140
Lines: 27

On Wed, May 09, 2012 at 09:20:08AM -0700, H Hartley Sweeten wrote:
> Refactor the sysfs attributes and functions to remove
> the need for the forward declarations and use the
> DEVICE_ATTR macro to define them.
> 
> Instead of individually creating sysfs device attribute
> files, wrap them in an attribute_group and use the
> sysfs_create_group function to create them.

This is great, and needed to be done, but you need to take this one step
further.  This attribute group needs to be registered by the driver
core, not the comedi core, so userspace doesn't get an add event before
the files are created.  To do that, assign this attribute group to the
class and the core will handle it for you.

I've taken this patch, but will you make a follow-on patch that makes
this change, which will remove this race?  It should be a net removal of
code in the comedi core overall.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/