Date: Wed, 9 May 2012 13:42:10 -0700
From: Greg KH <gregkh@linuxfoundation.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, devel@driverdev.osuosl.org,
        fmhess@users.sourceforge.net, abbotti@mev.co.uk
Subject: Re: [PATCH v2] staging: comedi: remove __user annotation inside of
 struct's
Message-ID: <20120509204210.GA22184@kroah.com>
References: <201205090936.03921.hartleys@visionengravers.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201205090936.03921.hartleys@visionengravers.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1267
Lines: 35

On Wed, May 09, 2012 at 09:36:03AM -0700, H Hartley Sweeten wrote:
> Remove the __user annotations in the struct definitions in
> comedi.h.
> 
> These structs are used to pass information from user-space
> to kernel-space. The copy_from_user and copy_to_user functions
> are used to transfer the data between the address spaces.
> 
> The drivers then use the information internally under the
> assumption that they are kernel-space objects. Having the
> __user annotations inside the structs produces a number of
> sparse warnings of the type:
> 
> warning: dereference of noderef expression
> 
> According to Grek Kroah-Hartman:
> 
> "When the kernel exports .h files, stuff like this should work
> "automatically", so there is no need to not put __user markings."

Wait, for some reason I thought you were adding __user markings, not
removing them from the structures.  That is why I said the above
statement.

Why again are you removing them?  Didn't you just cause more sparse
warnings to pop up?

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/