Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758896Ab2EIWeU (ORCPT ); Wed, 9 May 2012 18:34:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48944 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756028Ab2EIWeT (ORCPT ); Wed, 9 May 2012 18:34:19 -0400 Date: Wed, 9 May 2012 18:34:06 -0400 (EDT) From: Mikulas Patocka X-X-Sender: mpatocka@file.rdu.redhat.com To: Matt Turner cc: torvalds@linux-foundation.org, linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Rolf Eike Beer , "James E.J. Bottomley" , Helge Deller Subject: Re: [PATCH 5/5] PA-RISC: fix compile errors In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="185242623-560017539-1336602846=:1272" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3135 Lines: 74 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --185242623-560017539-1336602846=:1272 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE On Wed, 9 May 2012, Matt Turner wrote: > On Wed, May 9, 2012 at 6:19 PM, Mikulas Patocka wro= te: > > From: Rolf Eike Beer > > > > This was defined in asm/pdc.h which needs to include asm/page.h for > > __PAGE_OFFSET. This leads to an include loop so that page.h eventually = will > > include pdc.h again. While this is no problem because of header guards,= it is > > a problem because some symbols may be undefined. Such an error is this: > > > > In file included from /home/buildbot/repos/linux/include/linux/bitops.h= :35:0, > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 from /home/buildbot/repos/linux/include= /asm-generic/getorder.h:7, > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 from /home/buildbot/repos/linux/arch/pa= risc/include/asm/page.h:162, > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 from /home/buildbot/repos/linux/arch/pa= risc/include/asm/pdc.h:346, > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 from /home/buildbot/repos/linux/arch/pa= risc/include/asm/processor.h:16, > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 from /home/buildbot/repos/linux/arch/pa= risc/include/asm/spinlock.h:6, > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 from /home/buildbot/repos/linux/arch/pa= risc/include/asm/atomic.h:20, > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 from /home/buildbot/repos/linux/include= /linux/atomic.h:4, > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 from /home/buildbot/repos/linux/include= /linux/sysfs.h:20, > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 from /home/buildbot/repos/linux/include= /linux/kobject.h:21, > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 from /home/buildbot/repos/linux/include= /linux/device.h:17, > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 from /home/buildbot/repos/linux/include= /linux/eisa.h:5, > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 from /home/buildbot/repos/linux/arch/pa= risc/kernel/pci.c:11: > > /home/buildbot/repos/linux/arch/parisc/include/asm/bitops.h: In functio= n "set_bit": > > /home/buildbot/repos/linux/arch/parisc/include/asm/bitops.h:82:2: error= : implicit declaration of function "_atomic_spin_lock_irqsave" [-Werror=3Di= mplicit-function-declaration] > > /home/buildbot/repos/linux/arch/parisc/include/asm/bitops.h:84:2: error= : implicit declaration of function "_atomic_spin_unlock_irqrestore" [-Werro= r=3Dimplicit-function-declaration] > > > > Signed-off-by: Rolf Eike Beer >=20 > Email address got eaten? I was copying the patch from mailing list web archive and it mangles=20 addresses. I fixed the others addresses, but forgot about this one. Mikulas > > Signed-off-by: Mikulas Patocka >=20 --185242623-560017539-1336602846=:1272-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/