Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757444Ab2EJBSf (ORCPT ); Wed, 9 May 2012 21:18:35 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:56174 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756994Ab2EJBSc (ORCPT ); Wed, 9 May 2012 21:18:32 -0400 MIME-Version: 1.0 In-Reply-To: <1336611278.728.9.camel@mop> References: <1336004953.4240.9.camel@mop> <1336475689.1179.12.camel@mop> <20120509070710.GA29981@gmail.com> <1336611278.728.9.camel@mop> From: Linus Torvalds Date: Wed, 9 May 2012 18:18:11 -0700 X-Google-Sender-Auth: FdbUS00T8mHpcS4SwuiHkIrrYX8 Message-ID: Subject: Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer To: Kay Sievers Cc: Ingo Molnar , Jonathan Corbet , Sasha Levin , Greg Kroah-Hartmann , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 814 Lines: 19 On Wed, May 9, 2012 at 5:54 PM, Kay Sievers wrote: > > How about this? It relaxes the need for KERN_CONT, but it limits > continuation lines to repeated calls of the same thread. Fair enough, looks reasonable. Except your case-statement sucks. Having a "case 'c':" that basically then immediately has an "if (it was not 'c')" is just disturbing. Just move the code that is common to all the cases outside the case statement entirely, and make the 'c' case not do anything at all, and remove that crazy extraneous if-statement. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/