Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757956Ab2EJBY4 (ORCPT ); Wed, 9 May 2012 21:24:56 -0400 Received: from ch1ehsobe003.messaging.microsoft.com ([216.32.181.183]:7175 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755165Ab2EJBYy (ORCPT ); Wed, 9 May 2012 21:24:54 -0400 X-SpamScore: -16 X-BigFish: VS-16(zz9feN1432N98dK4015Izz1202hzz8275dhz2dh2a8h668h839h944hd25hd2bh) X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI Date: Thu, 10 May 2012 09:24:23 +0800 From: Peter Chen To: NeilBrown CC: Samuel Ortiz , Felipe Balbi , Grazvydas Ignotas , Greg Kroah-Hartman , , , Subject: Re: [PATCH 0/6] twl4030: Various fixes for charing-from-USB Message-ID: <20120510012422.GA32077@nchen-desktop> References: <20120425072931.20124.56635.stgit@notabene.brown> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20120425072931.20124.56635.stgit@notabene.brown> User-Agent: Mutt/1.5.20 (2009-06-14) X-OriginatorOrg: freescale.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2010 Lines: 57 On Wed, Apr 25, 2012 at 05:33:10PM +1000, NeilBrown wrote: > Following are a collection of patches that I've need using for a while > to make sure the charge-from-usb on my GTA04 works. > Hopefully I've included the right people in the recipient list :-) > > The issues are: > - charge the backup battery as well as the main battery > - charge from a charger which ties ID to ground via a resistor > - charge while device is suspended, or when no gadget module is > loaded (i.e. when the USB side thinks the phy should be powered > down). According to USB Spec, when the USB bus goes to suspend, the device should not draw more than 2.5mA. So when the device is suspended, it should notify the battery driver do NOT charge any more. > > Questions and comments more welcome. > > Thanks, > NeilBrown > > > --- > > NeilBrown (6): > twl4030-usb: Don't report EVENT_ID when there is VBUS. > twl4030-usb: Don't power down phy when it is in-use by charger. > twl4030_charger: Allow charger to control the regulator that feeds it. > twl4030_charger: allow charging whenever VBUS is present. > twl4030_charger: add backup-battery charging. > twl4030_charger: Fix some typos > > > drivers/mfd/twl-core.c | 9 ++-- > drivers/power/twl4030_charger.c | 86 +++++++++++++++++++++++++++++++++++---- > drivers/usb/otg/twl4030-usb.c | 27 ++++++++---- > include/linux/i2c/twl.h | 2 + > 4 files changed, 102 insertions(+), 22 deletions(-) > > -- > Signature > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/