Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754434Ab2EJCqO (ORCPT ); Wed, 9 May 2012 22:46:14 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:53350 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754179Ab2EJCqN (ORCPT ); Wed, 9 May 2012 22:46:13 -0400 Message-ID: <1336617972.1905.22.camel@joe2Laptop> Subject: Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer From: Joe Perches To: Kay Sievers Cc: Linus Torvalds , Ingo Molnar , Jonathan Corbet , Sasha Levin , Greg Kroah-Hartmann , linux-kernel@vger.kernel.org Date: Wed, 09 May 2012 19:46:12 -0700 In-Reply-To: <1336617173.25027.4.camel@mop> References: <1336004953.4240.9.camel@mop> <1336475689.1179.12.camel@mop> <20120509070710.GA29981@gmail.com> <1336611278.728.9.camel@mop> <1336617173.25027.4.camel@mop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 760 Lines: 27 On Thu, 2012-05-10 at 04:32 +0200, Kay Sievers wrote: > --- a/kernel/printk.c [] > @@ -1295,20 +1296,16 @@ asmlinkage int vprintk_emit(int facility > case '0' ... '7': > if (level == -1) > level = text[1] - '0'; > - text += 3; > - textlen -= 3; > - break; > - case 'c': /* KERN_CONT */ > - cont = true; > case 'd': /* KERN_DEFAULT */ > + prefix = true; > + case 'c': /* KERN_CONT */ trivia: Please add /* fallthrough */ comment lines so it shows the "missing" breaks are intentional. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/