Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756922Ab2EJHjE (ORCPT ); Thu, 10 May 2012 03:39:04 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:19029 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756066Ab2EJHjC (ORCPT ); Thu, 10 May 2012 03:39:02 -0400 Message-ID: <4FAB708C.9020600@atmel.com> Date: Thu, 10 May 2012 09:38:52 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Sergei Shtylyov CC: , , , , , , stable Subject: Re: [PATCH] USB: ohci-at91: add a reset function to fix race condition References: <1336553334-31058-1-git-send-email-nicolas.ferre@atmel.com> <4FAAA7CC.7050208@mvista.com> In-Reply-To: <4FAAA7CC.7050208@mvista.com> X-Enigmail-Version: 1.5pre Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.159.245.112] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2340 Lines: 72 On 05/09/2012 07:22 PM, Sergei Shtylyov : > Hello. > > On 09-05-2012 12:48, Nicolas Ferre wrote: > >> A possible race condition appears because we are not initializing >> the ohci->regs before calling usb_hcd_request_irqs(). >> We move the call to ohci_init() in hcd->driver->reset() instead of >> hcd->driver->start() to fix this. >> This was experienced when we share the same IRQ line between OHCI and >> EHCI >> controllers. > >> Signed-off-by: Nicolas Ferre >> Tested-by: Christian Eggers >> Cc: stable >> --- >> drivers/usb/host/ohci-at91.c | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) > >> diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c >> index 13ebeca..55d3d64 100644 >> --- a/drivers/usb/host/ohci-at91.c >> +++ b/drivers/usb/host/ohci-at91.c >> @@ -223,7 +223,7 @@ static void __devexit usb_hcd_at91_remove(struct >> usb_hcd *hcd, >> >> /*-------------------------------------------------------------------------*/ >> >> >> static int __devinit >> -ohci_at91_start (struct usb_hcd *hcd) >> +ohci_at91_reset (struct usb_hcd *hcd) > > Have you run the patch thru scripts/checkpatch.pl? There should be no > space between function name and '('. > >> { >> struct at91_usbh_data *board = >> hcd->self.controller->platform_data; >> struct ohci_hcd *ohci = hcd_to_ohci (hcd); >> @@ -233,6 +233,14 @@ ohci_at91_start (struct usb_hcd *hcd) >> return ret; >> >> ohci->num_ports = board->ports; >> + return 0; >> +} >> + >> +static int __devinit >> +ohci_at91_start (struct usb_hcd *hcd) > > Same here. > >> +{ >> + struct ohci_hcd *ohci = hcd_to_ohci (hcd); > > And here. Yes, I have run checkpatch.pl. But I also know that I have to conform to existing code and the history of the file that I am touching. This file is using this convention as well as drivers/usb/host/ohci-hcd.c and several others dealing with USB. So I kept this style in my patch. Best regards, -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/