Date: Thu, 10 May 2012 09:50:31 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
        torvalds@linux-foundation.org, joerg.roedel@amd.com,
        paul.gortmaker@windriver.com, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH 2/2] irq: use config_enabled(SMP) checks to cleanup
 irq_set_affinity() for UP
Message-ID: <20120510075031.GC28395@gmail.com>
References: <20120509093001.GD8585@gmail.com>
 <1336589196-14498-1-git-send-email-suresh.b.siddha@intel.com>
 <1336589196-14498-2-git-send-email-suresh.b.siddha@intel.com>
 <1336593505.4634.11.camel@sbsiddha-desk.sc.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1336593505.4634.11.camel@sbsiddha-desk.sc.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 995
Lines: 29


* Suresh Siddha <suresh.b.siddha@intel.com> wrote:

> On Wed, 2012-05-09 at 11:46 -0700, Suresh Siddha wrote:
> > Use config_enabled(SMP) checks for cleaning up the ifdef CONFIG_SMP around
> > irq_set_affinity routines in io_apic and irq_remapping subsystems.
> > 
> 
> Switched to IS_BUILTIN() instead. Thanks.

Hm, what was wrong with config_enabled(CONFIG_SMP)?

The IS_BUILTIN() macro is 1) shouting loud, needlessly 2) 
somewhat confusing for the CONFIG_SMP case: of course SMP is 
'built in', not modular - and the fact that 'built in' also 
implies 'enabled' is lost in that naming variant.

So I think IS_BUILTIN() makes more sense for genuine tri-state 
config knobs, and bools like CONFIG_SMP should se 
config_enabled()..

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/